Fix RequestNotRead crash in XGlean hook for multipart file uploads#143
Merged
Merged
Conversation
The XGlean hook reconstructed the httpx.Request to add headers, which accessed request.content — a property that raises RequestNotRead on streaming (multipart) bodies. This broke upload_files and upload_files_async. Mutate headers in place instead. Fixes GitHub issue #136 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chris-freeman-glean
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httpx.RequestNotReadcrash when callingupload_files/upload_files_async(GitHub issue upload_files()/upload_files_async() raises httpx.RequestNotRead #136)XGleanhook was reconstructing the entirehttpx.Requestto add headers, which accessedrequest.content— a property that raisesRequestNotReadon multipart (streaming) bodiesrequest.headersin place instead of reconstructing the requestTest plan
poetry run pytest tests/test_x_glean_hook.py)test_handles_multipart_streaming_requestreproduces the exact crash scenarioRequestNotRead, new code does notx_glean.pyand test file are not Speakeasy-managed (safe from regeneration)🤖 Generated with Claude Code